Skip to content

validateBstackJson & isCypressProjDirValid Fix #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

karanshah-browserstack
Copy link
Collaborator

Bug Fixes For :

  1. Adding stacktrace if browserstack.json is invalid
  2. isCypressProjDirValid fails if you have pass integrationFoldDir is not an absolute Dir.

nagpalkaran95
nagpalkaran95 previously approved these changes Sep 8, 2020
nagpalkaran95
nagpalkaran95 previously approved these changes Sep 8, 2020
@prateekbstack
Copy link
Collaborator

Tested for absolute and relative paths for both cypressProjectDir and integrationFolder. Works good with default cli dir as well as from any directory outside it with proper --config-file path for browserstack.json
Regression is pending, upon its completion, this will be QA approved

@karanshah-browserstack karanshah-browserstack merged commit e4681f5 into master Sep 14, 2020
@karanshah-browserstack karanshah-browserstack deleted the bug_fixes branch September 14, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants